Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused component VideoIframe #13055

Merged
merged 1 commit into from
May 28, 2024
Merged

Remove unused component VideoIframe #13055

merged 1 commit into from
May 28, 2024

Conversation

corwintines
Copy link
Member

Description

  • Removes VideoIframe component which is not used anywhere in the project

@netlify Netlify
Copy link

netlify bot commented May 27, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 5528839
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/665506330506860008028fd1
😎 Deploy Preview https://deploy-preview-13055--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 48 (🟢 up 10 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 3 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nhsz
nhsz approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@nhsz nhsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nhsz nhsz merged commit d5e7f7d into dev May 28, 2024
9 of 10 checks passed
@nhsz nhsz deleted the deprecateVideoIframe branch May 28, 2024 03:04
@corwintines corwintines mentioned this pull request May 28, 2024
Open
This was referenced Jun 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhsz nhsz nhsz approved these changes

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corwintines @nhsz