Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workflow skips dev/staging/master branches #13020

Merged
merged 4 commits into from
May 28, 2024
Merged

fix: workflow skips dev/staging/master branches #13020

merged 4 commits into from
May 28, 2024

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented May 22, 2024

Summary by CodeRabbit

  • Chores
    • Enhanced branch name checks to include 'dev', 'staging', and 'master' in addition to 'crowdin'.
    • Adjusted workflow to skip processing for specified branches.

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label May 22, 2024
Copy link

netlify bot commented May 22, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 6484c57
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6650e3239c1a1f0008ebb971
😎 Deploy Preview https://deploy-preview-13020--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 32 (🔴 down 6 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 3 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticing a build issue @wackerow. Will try to help look into this.

@wackerow
Copy link
Member Author

@coderabbitai review

Copy link
Contributor

coderabbitai bot commented May 23, 2024

Actions Performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Contributor

coderabbitai bot commented May 23, 2024

Walkthrough

The recent update enhances the branch name checking functionality in the GitHub Actions workflow by including 'dev', 'staging', and 'master' branches, in addition to 'crowdin'. This ensures that the workflow skips processing for these branches, improving efficiency and focusing checks only on relevant branches.

Changes

Files Change Summary
.github/workflows/non-english-warning.yml Enhanced check_branch_name job to include 'dev', 'staging', and 'master' branches. Adjusted check_changes job to skip execution based on the output of check_branch_name.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

.github/workflows/non-english-warning.yml Outdated Show resolved Hide resolved
.github/workflows/non-english-warning.yml Outdated Show resolved Hide resolved
@minimalsm minimalsm merged commit 5678325 into dev May 28, 2024
5 of 6 checks passed
@minimalsm minimalsm deleted the patch-workflow branch May 28, 2024 11:16
This was referenced Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants