refactor(layouts): create story and update style for base layout

[TylerAPfledderer]

Description

Create a story for RootLayout, now named BaseLayout to be in sync with naming in the DS.

Also makes slight layout adjustments to adhere to the DS.

[netlify]

✅ Deploy Preview for ethereumorg ready!

Name	Link
🔨 Latest commit	7989e90
🔍 Latest deploy log	https://app.netlify.com/sites/ethereumorg/deploys/667b23b810b2de0008849eb0
😎 Deploy Preview	https://deploy-preview-12960--ethereumorg.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	7 paths audited Performance: 43 (🔴 down 4 from production) Accessibility: 92 (no change from production) Best Practices: 83 (🔴 down 9 from production) SEO: 93 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[pettinarip]

Nice to see a story for this!!

[TylerAPfledderer]

I am aware of the current conflict with the old RootLayout in prod

[wackerow]

We refactored where we convert this Date into a readable string, and we're now passing lastDeployLocaleTimestamp instead of lastDeployDate. Updated the two instances of this variable name which fixed the build issue locally for me.

[wackerow]

Lgtm!

[wackerow]

Seeing 113 items in the Chromatic change set. These look good to me, but @TylerAPfledderer should @nloureiro sign off on these before pulling in?

[TylerAPfledderer]

Seeing 113 items in the Chromatic change set. These look good to me, but @TylerAPfledderer should @nloureiro sign off on these before pulling in?

We are trying to leave them to review during staging

[nloureiro]

yes, I went through all of the differences, and they seem ok. approved on chromatic

[pettinarip]

Seeing 113 items in the Chromatic change set. These look good to me, but @TylerAPfledderer should @nloureiro sign off on these before pulling in?

We are trying to leave them to review during staging

Is that necessary? maybe Im not following you on what you mean with staging but shouldn't they all appear when we create the PR pointing to staging?

I think we should review & fix them if we are adding them here since that is the scope of the PR, right?

[TylerAPfledderer]

Seeing 113 items in the Chromatic change set. These look good to me, but @TylerAPfledderer should @nloureiro sign off on these before pulling in?

We are trying to leave them to review during staging

Is that necessary? maybe Im not following you on what you mean with staging but shouldn't they all appear when we create the PR pointing to staging?

I think we should review & fix them if we are adding them here since that is the scope of the PR, right?

I recall having the discussion previously during the QA sessions. So that Nuno is not tasked to look over every single PR that had a change, we leave the UI Review check open for Nuno to view changeset during the QA Session days when the deploy PR is created. As the final "signoff" of sorts.

If it appears that might not be ideal, then should that check block these PRs until Nuno approves it?

[corwintines]

LGTM!