Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "What is Ether and Ethereum?" video #129

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Added "What is Ether and Ethereum?" video #129

merged 1 commit into from
Jul 24, 2019

Conversation

jjmstark
Copy link
Contributor

  • Added video to the "Ethereum basics" section, which previously lacked any video content
  • First noticed the video here: https://twitter.com/ameensol/status/1148453238754045952
  • Added as the second bullet point (rather than at bottom of list) because it's valuable, especially for beginner content, to give the reader of a video option, rather than long articles. The fact that this is the only video in this section warranted including it higher-up.

- Added video to the "Ethereum basics" section, which previously lacked any video content
- First noticed the video here: https://twitter.com/ameensol/status/1148453238754045952
- Added as the second bullet point because it's valuable, especially for beginner content, to give the reader of a video option, rather than long articles. The fact that this is the only video in this section warranted including it higher-up.
@jjmstark jjmstark requested a review from ethjoe July 17, 2019 15:52
@ethjoe
Copy link
Contributor

ethjoe commented Jul 18, 2019

Commentary on the video:

First -- this is about as good as these things will get -- short, edited well, complete, and not future proof but semi-current.

A few notes -- The one that stands out is the "...additionally, Ether can be used as an investment!" mention at the end. Other potential hiccups are the mention of data storage as a purpose of contracts which is its own conversation, and the heavy use of the term 'smart contract' (but that's a very minor point).

@jjmstark jjmstark merged commit 741b252 into dev Jul 24, 2019
@samajammin samajammin deleted the jjmstark-patch-3 branch November 29, 2019 16:01
wackerow pushed a commit to TylerAPfledderer/ethereum-org-website that referenced this pull request Nov 28, 2023
…age-prop-types

refactor([...slug]): update type constraints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants