update the position of the tooltip and set it near the label text #12779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dharmik79
requested review from
wackerow,
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wackerow
requested changes
Apr 24, 2024
src/components/FindWallet/WalletTable/WalletMoreInfoCategory.tsx
Outdated
Show resolved
Hide resolved
wackerow
reviewed
May 27, 2024
src/components/FindWallet/WalletTable/WalletMoreInfoCategory.tsx
Outdated
Show resolved
Hide resolved
corwintines
added
the
needs design approval 🧑🎨
|
Circling through, still seeing buggy positioning... going to switch this to draft mode. |
|
Just to confirm what you mean by buggy positioning @wackerow, is it because the Tooltip icon is aligning with the top of the text, and not center? |
|
@corwintines I'm seeing this 
..with the info icon for "Hardware wallet support" on it's own line |
wackerow
requested changes
Jun 25, 2024
src/components/FindWallet/WalletTable/WalletMoreInfoCategory.tsx
Outdated
Show resolved
Hide resolved
wackerow
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the tooltip inside the feature label text and made the list item aligned horizontally
Preview URL
https://deploy-preview-12779--ethereumorg.netlify.app/en/wallets/find-wallet
Related issue