-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storybook): build story modes #12668
feat(storybook): build story modes #12668
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
31b56ea
to
64476c2
Compare
@nloureiro would like your review on this. Visit the below link to the Chromatic changeset for this build to see the current set of snapshots: A couple of things to note:
cc @pettinarip |
|
Thanks for the update @TylerAPfledderer! Should we mark as draft until these are checked off? |
Ah yes, probably should. Will do that now! |
|
@pettinarip now with the Chakra addon removed in favor of a local setup, and Farsi added as a locale option, we should be all set here with RTL story modes! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @TylerAPfledderer, thanks!
Description
This PR adds Story mode configurations to Storybook, which generate in Chromatic various snapshots for different view settings. These can include a snapshot per viewport width, dark mode, language, etc.
px
andem
(coming from the Chakra default theme)en
,ru
,uk
,zh
)HubHero
HomeHero
ContentHero
MdxHero
Related Issue
Closes #12656