revert: removal of old page-languages ns strings #12636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wackerow
requested review from
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
github-actions
bot
added
review needed 👀
translation 🌍
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pettinarip
reviewed
Apr 3, 2024
There was a problem hiding this comment.
@wackerow shouldn't we also remove the src/intl/cs/page-languages.json file that was created?
|
Yes... I also updated this to do the same for |
wackerow
added
needs dev approval 🧑💻
|
@wackerow I see some conflicts with the deleted json files. Let me see if I can resolve them. |
pettinarip
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
@wackerow fixed the conflicts. Once it finishes building I think we should be good to go.
This was referenced Apr 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
page-languages.jsonnamespace was recently merged intocommon.jsonin PR:The Crowdin imports in
are not yet updated with these changes, which accidentally removed these strings.
Affects strings with keys beginning with
language-orpage-languages--- see diff, filesrc/intl/en/page-languages.json(Sorting applied)
Related Issue