Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update quiz questions and prompts #12600

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Update quiz questions and prompts #12600

merged 4 commits into from
Jun 11, 2024

Conversation

corwintines
Copy link
Member

@github-actions github-actions bot added review needed 👀 translation 🌍 This is related to our Translation Program labels Mar 29, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 29, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 4634b42
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6668d9a4eb2acc0008cb3291
😎 Deploy Preview https://deploy-preview-12600--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 30 (🔴 down 8 from production)
Accessibility: 93 (🟢 up 1 from production)
Best Practices: 92 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

wackerow
wackerow reviewed Apr 8, 2024
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few thoughts @corwintines

src/intl/en/learn-quizzes.json Outdated Show resolved Hide resolved
src/intl/en/learn-quizzes.json Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label May 9, 2024
@wackerow wackerow added content 🖋️ This involves copy additions or edits and removed needs review 👀 translation 🌍 This is related to our Translation Program Status: Stale This issue is stale because it has been open 30 days with no activity. labels May 22, 2024
@wackerow wackerow marked this pull request as draft May 25, 2024 16:06
@github-actions github-actions bot added the translation 🌍 This is related to our Translation Program label Jun 11, 2024
@corwintines corwintines marked this pull request as ready for review June 11, 2024 23:08
@corwintines
Copy link
Member Author

brought your suggestions in @wackerow, I think this should be good now

@wackerow wackerow merged commit 3d4d784 into dev Jun 11, 2024
2 checks passed
@wackerow wackerow deleted the quizQuestionUpdates branch June 11, 2024 23:12
This was referenced Jun 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wackerow wackerow wackerow approved these changes

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

@nhsz nhsz Awaiting requested review from nhsz

Assignees
No one assigned
Labels
content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program
Projects
None yet
Milestone
No milestone
2 participants
@corwintines @wackerow