Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: /wallets/find-wallet revamp ✨ #12522

Merged
merged 265 commits into from
Mar 21, 2024
Merged

feat: /wallets/find-wallet revamp ✨ #12522

merged 265 commits into from
Mar 21, 2024

Conversation

nhsz
Copy link
Member

@nhsz nhsz commented Mar 20, 2024

This PR implements a new iteration of the /wallets/find-wallet page, including UI updates for both desktop & mobile, filters revamp, bugfixes and other requested features

Preview: https://deploy-preview-12522--ethereumorg.netlify.app/en/wallets/find-wallet/

Description

  • changes to WalletTable

    • updates wallet table layout
    • updates WalletMoreInfo layout
    • updates WalletMoreInfoCategory component
    • updates useWalletTable hook
    • adds useWalletPersonas hook
    • adds getWalletPersonas util
    • adds getSupportedLanguages util
    • adds formatSupportedLanguages util
    • adds useLanguagesList hook
    • adds supported devices list to table UI
    • adds supported languages list to table UI
    • updates icons used on table
    • adds DevicesIcon, LanguagesIcon
    • updates i18n namespaces used for /find-wallet
    • updates table heading styles
    • updates contants.ts
  • components

    • updates WalletFilterProfile component
    • updates WalletFilterSidebar component
    • updates WalletsTable styles
      • change background color to background.highlight when expanded
    • updates WalletMoreInfo styles
    • updates WalletMoreInfoCategory styles
    • adds WalletFilterPersona component
    • adds SupportedLanguagesTooltip component
    • adds MobileFiltersMenu component (see new mobile menu design)
    • adds ResetFiltersButton component
    • adds LanguageSupportFilter component
    • adds MobileFiltersButton component
    • adds WalletSocialLinks component
  • filters

    • updates featureDropdownItems
    • updates filterOptions
    • adds persona filter title
    • adds Advanced label/category to filters
    • removes eip_1559_support feature filter
    • features filter
      • remove description for devices
  • utils

    • adds getPersonaBorderColor util
    • adds getLocaleFormattedDate util
    • adds getLanguageCodeNameutil
    • adds capitalize util
    • adds getAllWalletsLanguages util
    • adds walletsListingCount util
    • adds getWalletsTopLanguages util
  • hooks

    • moves useWalletTable inside /hooks dir
    • moves useWalletFilterFeature inside /hooks dir
  • constants

    • adds WALLETS_FILTERS_DEFAULT constant
  • types

    • adds WalletFilter type
    • adds WalletSupportedLanguageContextType type
  • icons

    • removes unused EIP1559Icon
  • wallets data

    • fixes inconsistent wallet.last_updated format
  • translations

    • adds page-find-wallet-personas-title key
    • adds page-find-wallet-see-wallets key
    • updates page-find-wallet-non-custodial value
    • updates page-find-wallet-connect-to-dapps-desc value
    • removes page-find-choose-to-compare unused key
    • removes page-find-wallet-choose-to-compare unused key
    • removes page-find-wallet-persona-desc unused key
    • removes page-find-wallet-profile-filters unused key
    • removes page-find-wallet-feature-filters unused key
    • removes page-find-wallet-fee-optimization unused key
    • removes page-find-wallet-fee-optimization-desc unused key
    • removes page-find-wallet-mobile-desc unused key
    • removes page-find-wallet-desktop-desc unused key
    • removes page-find-wallet-browser-desc unused key
    • removes page-find-wallet-hardware-desc unused key
    • removes page-find-wallet-choose-features unused key
    • removes page-find-wallet-walletconnect unused key
    • removes page-find-wallet-walletconnect-desc unused key
    • removes page-find-wallet-token-support unused key

nhsz and others added 30 commits January 29, 2024 14:59
@github-actions github-actions bot added dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Mar 20, 2024
@nhsz nhsz removed translation 🌍 This is related to our Translation Program dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project labels Mar 20, 2024
Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit fe4edc8
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65fb5d7d0d4ab80008efbe3c
😎 Deploy Preview https://deploy-preview-12522--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Mar 20, 2024
@nhsz nhsz removed translation 🌍 This is related to our Translation Program dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project labels Mar 20, 2024
@github-actions github-actions bot added dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Mar 20, 2024
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Great job @nhsz 🎉

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@pettinarip pettinarip merged commit eadc633 into dev Mar 21, 2024
9 of 10 checks passed
@pettinarip pettinarip deleted the find-wallet-revamp branch March 21, 2024 15:25
This was referenced Mar 26, 2024
Copy link

netlify bot commented Mar 28, 2024

A new user left a comment. This user must be approved by a Netlify team owner before comments can be displayed.

Approve this user

1 similar comment
@LilaRox120
Copy link

A new user left a comment. This user must be approved by a Netlify team owner before comments can be displayed.

Approve this user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies epic 💪 This issue is an epic on our product roadmap feature ✨ This is enhancing something existing or creating something new high priority This has a high priority refactor ♻️ Changes which don't affect functionality tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program wallet 👛 This issue relates to adding or changing a wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants