Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken links from /enterprise/* #12496

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

HiroyukiNaito
Copy link
Contributor

@HiroyukiNaito HiroyukiNaito commented Mar 19, 2024

Delete site link: Hyperleader burrow link expired and is no longer maintained.

Description

Delete site link: Hyperleader burrow link expired and is no longer maintained.

Related Issue

None

Summary by CodeRabbit

  • Documentation
    • Updated information on Hyperledger's involvement with Ethereum, focusing on Hyperledger Besu.

Copy link
Contributor

coderabbitai bot commented Mar 19, 2024

Walkthrough

The update involves refining the information related to Hyperledger's integration with the Ethereum ecosystem. It specifically eliminates references to Hyperledger Burrow, emphasizing Hyperledger Besu's role within the Ethereum stack. This change reflects a shift in focus or relevance within the context of private Ethereum networks, highlighting Besu as the primary Hyperledger project for Ethereum compatibility and collaboration.

Changes

Files Change Summary
public/.../private-ethereum/index.md Removed Hyperledger Burrow; emphasized Hyperledger Besu in Ethereum context.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Mar 19, 2024
Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 3977ae7
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65fb1ca487412e0008dfbe9c
😎 Deploy Preview https://deploy-preview-12496--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between f920ff1 and 3b93307.
Files selected for processing (1)
  • public/content/enterprise/private-ethereum/index.md (1 hunks)
Additional comments: 1
public/content/enterprise/private-ethereum/index.md (1)
  • 20-20: The update focuses on Hyperledger's involvement with the Ethereum stack, specifically mentioning Hyperledger Besu. This change aligns with the PR objectives to update the content related to Hyperledger. However, it's crucial to ensure that all external links, including the one to Hyperledger Besu, are current and lead to active, relevant pages. Regularly checking and updating such links is essential for maintaining the accuracy and reliability of the website's content.

rm links to Hyperledger Burrow
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @HiroyukiNaito... I just stripped this link out of the non-English versions of this page as well.

Where the "Burrow" link is ending the sentence, I've only removed the link, keeping the sentence as is... In English this has been removed and the actual text will eventually get updated through Crowdin for the non-English versions.

The bullet entry for Hyperledger Burrow I just removed throughout.

@wackerow wackerow changed the title Delete site link: Hyperleader burrow link expired and is no longer maintained. Remove broken links from /enterprise/* Mar 20, 2024
@wackerow wackerow merged commit 5f93892 into ethereum:dev Mar 20, 2024
2 checks passed
This was referenced Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants