Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max blobs per block should be 6 not 1 #12456

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

blmalone
Copy link
Contributor

@blmalone blmalone commented Mar 14, 2024

Blobs per block is not 1 but 6.

Description

eip-4844: states that the max size is 0.75 MB which is equivalent to 6, 125kb blobs.

Related Issue

Summary by CodeRabbit

  • Documentation
    • Updated the roadmap section on Danksharding to reflect the increase in the number of blobs attached to blocks from 6 in Proto-Danksharding to 64 in full Danksharding, along with the necessary adjustments for consensus client operations.

Blobs per block is not 1 but 6.
@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Mar 14, 2024
Copy link
Contributor

coderabbitai bot commented Mar 14, 2024

Walkthrough

The update signifies a transition from Proto-Danksharding to full Danksharding, specifically increasing the number of blobs attached to blocks from 6 to 64. This major shift will require consensus client operations to adapt to the significantly larger blob size, alongside other planned adjustments to accommodate this enhancement in blockchain efficiency and scalability.

Changes

File(s) Change Summary
public/content/roadmap/.../index.md Updated the number of blobs attached to blocks from 6 in Proto-Danksharding to 64 in full Danksharding. This update necessitates modifications to consensus client operations to manage the increased blob size, with further changes anticipated for other purposes.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 665d790
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65f34ff2e6af9700085be49b
😎 Deploy Preview https://deploy-preview-12456--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wackerow wackerow merged commit e8313d3 into ethereum:dev Mar 14, 2024
5 of 6 checks passed
Copy link

gitpoap-bot bot commented Mar 14, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@wackerow
Copy link
Member

@all-contributors please add @blmalone for content correction

Copy link
Contributor

@wackerow

I've put up a pull request to add @blmalone! 🎉

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between b1d4f64 and 665d790.
Files selected for processing (1)
  • public/content/roadmap/danksharding/index.md (1 hunks)
Additional comments: 1
public/content/roadmap/danksharding/index.md (1)
  • 68-68: The update from 6 blobs in Proto-Danksharding to 64 in full Danksharding is a significant change that aligns with the Ethereum protocol's scalability goals. Ensure this update is reflected in all relevant documentation and educational materials to maintain consistency and clarity for the community.

This was referenced Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants