feat: update history page for dencun #12438
Conversation
wackerow
requested review from
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
WalkthroughThe recent update involves a few notable adjustments to the network upgrade summary data. Specifically, the update has eliminated the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- src/data/NetworkUpgradeSummaryData.ts (1 hunks)
Check Runs (1)
label completed (2)
Additional comments: 4
src/data/NetworkUpgradeSummaryData.ts (4)
- 6-6: The update to
ethPriceInUSDfor the Dencun upgrade to 3984 seems accurate and aligns with the PR's objective to keep the/historypage current.- 7-8: The update to
waybackLinkfor the Dencun upgrade seems appropriate. Please ensure the URL is accurate and leads to the intended historical snapshot.- 9-9: The addition of
blockNumberfor the Dencun upgrade enhances the completeness and relevance of the upgrade data.- 5-9: The removal of the
isPendingproperty, as mentioned in the summary, likely indicates the finalization of the Dencun upgrade. This change aligns with the objective to keep the/historypage current.
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- public/content/history/index.md (1 hunks)
Check Runs (1)
label completed (2)
Additional comments: 4
public/content/history/index.md (4)
- 70-76: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
The document starts with front matter metadata for the page. Ensure that the
title,description,lang, andsidebarDepthaccurately reflect the content and intended use of the page.
- 73-73: The section header "Cancun-Deneb ('Dencun')" correctly combines the names of the execution and consensus upgrades, following the pattern established with "Shanghai-Capella ('Shapella')". This naming convention helps simplify references to these upgrades using a single term.
- 70-76: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [80-81]
The mention of "Proto-Danksharding" introduces a significant upgrade aimed at improving scalability and reducing transaction fees for layer 2 rollups. It's crucial to ensure that the explanation is clear and that links to further reading are provided for users seeking more detailed information.
- 70-76: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [96-98]
The links provided under the "Cancun summary" section offer valuable resources for readers interested in exploring layer 2 rollups, Proto-Danksharding, and Danksharding in more detail. It's important to verify that these links are up-to-date and lead to relevant and accurate information.
Verification successful
The verification process confirms that the external links mentioned in the document are valid. The first link (https://eips.ethereum.org/EIPS/eip-4844) directly leads to the intended resource, indicating its validity with a 200 HTTP status code. The other three links are redirected to new URLs, as indicated by the 301 HTTP status codes, but remain accessible. This suggests that while the links have been moved, they are not broken, and efforts have been made to maintain access to the relevant information. Therefore, the links provided under the "Cancun summary" section are up-to-date in terms of accessibility.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the validity of external links mentioned in the document. curl --head https://eips.ethereum.org/EIPS/eip-4844 curl --head https://ethereum.org/layer-2/ curl --head https://ethereum.org/roadmap/scaling/#proto-danksharding curl --head https://ethereum.org/roadmap/danksharding/Length of output: 2746
There was a problem hiding this comment.
Review Status
Actionable comments generated: 5
Configuration used: CodeRabbit UI
Files selected for processing (1)
- public/content/history/index.md (3 hunks)
Check Runs (1)
label completed (2)
Additional comments: 3
public/content/history/index.md (3)
- 35-35: The spelling of "Cancun" has been corrected from "Cancun" to "Cancun". This change improves the consistency and accuracy of the document.
- 73-73: The section header "Cancun-Deneb" has been updated in the 2024 section. This change aligns with the objective to provide updated and accurate information regarding the Dencun upgrade.
- 32-38: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [10-10]
Consider revising "What are forks?" to avoid potential spelling or grammatical issues. While the context seems correct, ensuring clarity and precision in definitions can enhance understanding for readers.
| | Berlin | 2015 | 0 | Apr 15, 2021 | | ||
| | London | 2016 | I | Aug 5, 2021 | | ||
| | Shanghai | 2017 | II | Apr 12, 2023 | | ||
| | **_Cancun_** | 2018 | III | Mar 13, 2024 | | ||
| | **Cancun** | 2018 | III | Mar 13, 2024 | | ||
| | _Prague_ | 2019 | IV | TBD | | ||
| | _Osaka_ | 2020 | V | TBD | | ||
| | _Bogota_ | 2022 | VI | TBD | |
There was a problem hiding this comment.
📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
The YAML front matter at the beginning of the file should start with an uppercase letter for consistency and proper Markdown formatting.
- title: History and Forks of Ethereum
+ Title: History and Forks of Ethereum📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [16-16]
The term "centrally-controlled" does not require a hyphen when the first word ends in 'ly'. Consider revising for grammatical accuracy.
- centrally-controlled software
+ centrally controlled software📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [18-18]
There's a potential missing comma after "unison" which could improve the readability of the sentence.
- changes in unison and the fork
+ changes in unison, and the fork📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [28-39]
The repeated whitespace in the table listing the upgrade names, years, and dates should be removed for cleaner Markdown formatting.
- | Berlin | 2015 | 0 | Apr 15, 2021 |
+ | Berlin | 2015 | 0 | Apr 15, 2021 |
- | London | 2016 | I | Aug 5, 2021 |
+ | London | 2016 | I | Aug 5, 2021 |
- | Shanghai | 2017 | II | Apr 12, 2023 |
+ | Shanghai | 2017 | II | Apr 12, 2023 |
- | **Cancun** | 2018 | III | Mar 13, 2024 |
+ | **Cancun** | 2018 | III | Mar 13, 2024 |
- | _Prague_ | 2019 | IV | TBD |
+ | _Prague_ | 2019 | IV | TBD |
- | _Osaka_ | 2020 | V | TBD |
+ | _Osaka_ | 2020 | V | TBD |
- | _Bogota_ | 2022 | VI | TBD |
+ | _Bogota_ | 2022 | VI | TBD |
- | _Bangkok_ | 2024 | VII | TBD |
+ | _Bangkok_ | 2024 | VII | TBD |Note: Apply this change to all instances of repeated whitespace in the table.
| @@ -32,7 +32,7 @@ | |||
| | Berlin | 2015 | 0 | Apr 15, 2021 | | |||
| | London | 2016 | I | Aug 5, 2021 | | |||
| | Shanghai | 2017 | II | Apr 12, 2023 | | |||
| | **_Cancun_** | 2018 | III | Mar 13, 2024 | | |||
| | **Cancun** | 2018 | III | Mar 13, 2024 | | |||
| | _Prague_ | 2019 | IV | TBD | | |||
| | _Osaka_ | 2020 | V | TBD | | |||
| | _Bogota_ | 2022 | VI | TBD | | |||
There was a problem hiding this comment.
The city name "Bogota" should include the diacritic mark for accuracy. It's spelled as "Bogotá".
- | _Bogota_ | 2022 | VI | TBD |
+ | _Bogotá_ | 2022 | VI | TBD |Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| | _Bogota_ | 2022 | VI | TBD | | |
| | _Bogotá_ | 2022 | VI | TBD | |
Description
Related Issue
Dencun updates