Fix tooltip positioning and closing in mobile #12423

pettinarip · 2024-03-11T16:58:54Z

Summary by CodeRabbit

Refactor
- Improved the Tooltip component's behavior on mobile devices by automatically closing it upon scrolling.

coderabbitai · 2024-03-11T16:59:00Z

Walkthrough

The update to the Tooltip component enhances state management and user experience. It integrates the useDisclosure hook from Chakra UI for efficient visibility control. A new useEffect hook ensures the tooltip closes on mobile scroll, improving responsiveness. Removing the strategy prop from the Popover component simplifies configuration while maintaining functionality.

Changes

File Path	Change Summary
`src/components/Tooltip/index.tsx`	- Imported and used `useDisclosure` from Chakra UI for popover state management - Added `useEffect` for mobile scroll handling - Removed `strategy` prop from `Popover`

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

netlify · 2024-03-11T16:59:14Z

✅ Deploy Preview for ethereumorg ready!

Name	Link
🔨 Latest commit	`4c6cb92`
🔍 Latest deploy log	https://app.netlify.com/sites/ethereumorg/deploys/65f40a57eacb3e0008a5a9a0
😎 Deploy Preview	https://deploy-preview-12423--ethereumorg.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 2ce32ca and f9f3516.

Files selected for processing (1)

src/components/Tooltip/index.tsx (2 hunks)

Additional comments: 3

src/components/Tooltip/index.tsx (3)

1-9: The import of useDisclosure from Chakra UI is correctly implemented and aligns with the PR's objective to enhance state management for the tooltip's visibility. This change leverages Chakra UI's built-in functionality for a more standardized approach.

39-44: The integration of isOpen, onOpen, and onClose from useDisclosure into the Popover component's props is correctly done, ensuring that the tooltip's visibility is managed effectively. This change supports the PR's goal of improving the tooltip's behavior on mobile devices.

39-44: While the removal of the strategy prop from the Popover component is not directly visible in the provided code, it's mentioned in the PR's objectives and AI-generated summary. Assuming this change was made as part of the PR, it's important to ensure that the default positioning behavior of the Popover component aligns with the intended user experience across all platforms, especially on mobile devices where screen real estate is limited.

Please verify that the default positioning behavior of the Popover component without the strategy prop meets the intended design and usability goals on all platforms, particularly on mobile devices.

src/components/Tooltip/index.tsx

wackerow · 2024-03-14T19:44:12Z

src/components/Tooltip/index.tsx

+      if (isOpen) {
+        onClose()
+      }


Consider a guard clause

Suggested change

if (isOpen) {

onClose()

}

if (!isOpen) return

onClose()

...or we could consider removing the check all together, but I think this is good

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between f9f3516 and 4c6cb92.

Files selected for processing (1)

src/components/Tooltip/index.tsx (1 hunks)

Files skipped from review as they are similar to previous changes (1)

src/components/Tooltip/index.tsx

wackerow

Looks great! Thanks @pettinarip!

wackerow · 2024-03-20T04:29:31Z

src/components/Tooltip/index.tsx

+      if (isOpen && Math.abs(delta) > 80) {
+        onClose()
+      }


This works great! I like that it doesn't close from the slightest nudge... it feels natural

fix tooltip positining and closing in mobile

f9f3516

pettinarip requested review from wackerow, corwintines, minimalsm and nhsz as code owners March 11, 2024 16:58

github-actions bot added the review needed 👀 label Mar 11, 2024

coderabbitai bot reviewed Mar 11, 2024

View reviewed changes

src/components/Tooltip/index.tsx Outdated Show resolved Hide resolved

Merge branch 'dev' into fix-tooltip-mobile

816f871

corwintines changed the base branch from dev to staging March 13, 2024 17:38

corwintines changed the base branch from staging to dev March 14, 2024 04:45

close tooltip if the user scrolls more than 80px

4c6cb92

wackerow reviewed Mar 14, 2024

View reviewed changes

coderabbitai bot reviewed Mar 15, 2024

View reviewed changes

wackerow approved these changes Mar 20, 2024

View reviewed changes

wackerow merged commit 69d9c7d into dev Mar 20, 2024
10 checks passed

wackerow deleted the fix-tooltip-mobile branch March 20, 2024 04:30

This was referenced Mar 26, 2024

Release candidate v8.4.0 #12583

Merged

Deploy v8.4.0 #12586

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix tooltip positioning and closing in mobile #12423

Fix tooltip positioning and closing in mobile #12423

pettinarip commented Mar 11, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 11, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

netlify bot commented Mar 11, 2024 •

edited

Loading

coderabbitai bot left a comment

wackerow Mar 14, 2024

coderabbitai bot left a comment

wackerow left a comment

wackerow Mar 20, 2024

Fix tooltip positioning and closing in mobile #12423

Fix tooltip positioning and closing in mobile #12423

Conversation

pettinarip commented Mar 11, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Mar 11, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

netlify bot commented Mar 11, 2024 • edited Loading

✅ Deploy Preview for ethereumorg ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

wackerow Mar 14, 2024

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

wackerow left a comment

Choose a reason for hiding this comment

wackerow Mar 20, 2024

Choose a reason for hiding this comment

pettinarip commented Mar 11, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 11, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

netlify bot commented Mar 11, 2024 •

edited

Loading