Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
/roadmap/dencun/
page #12413Add
/roadmap/dencun/
page #12413Changes from 13 commits
16f3fdc
d6f68e5
579c48a
79707e3
ffcfb33
0ecda90
e58f161
6f5cbd2
83525b9
4edb07e
5500dac
0ac0801
95e08bd
d2b1348
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the content is well-structured, providing a comprehensive overview of the Dencun upgrade, its implications, and related concepts. However, consider the following suggestions to enhance clarity, accuracy, and user engagement:
Spelling and Grammar: Ensure all technical terms and names are spelled correctly throughout the document. This includes terms like "Proto-Danksharding," "Dencun," and "Ethereum." While the static analysis hints at possible spelling mistakes, these are likely false positives due to the technical nature of the content. However, it's crucial to maintain consistency in the spelling of these terms.
Video Placement and Headline (Lines 102-111): Based on the feedback from the PR comments, consider moving the video content closer to the top of the page. This adjustment could cater to visual learners early on and potentially increase engagement with the content. While the current pattern follows existing practices, evolving the content layout based on user feedback and behavior is beneficial.
Further Reading Section (Lines 112-120): The further reading section is well-curated, providing readers with additional resources for a deeper understanding of the Dencun upgrade and related topics. Ensure all external links are up-to-date and accessible to maintain the section's value.
Content Accuracy and Completeness: Given the feedback suggesting the inclusion of details about other EIPs involved in the Dencun fork, verify that the document comprehensively covers all significant aspects of the upgrade. If necessary, add information about the deactivation of SELFDESTRUCT and new opcodes introduced by EIPs 1153 and 5656, ensuring the content remains informative and up-to-date.
Avoiding Redundancy: In some sections, phrases like "a variety of reasons" (Line 48) and "specific details" (Line 83) could be simplified to make the content more concise. Consider revising these to enhance readability without losing meaning.
Economic Section Removal: Confirm that the removal of the economics section, as mentioned in the PR comments, aligns with the community's feedback and the document's objectives. Ensure the remaining content adequately addresses users' informational needs without the economics perspective.
Consider incorporating these suggestions to improve the document's clarity, engagement, and comprehensiveness.