Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Argent Open Source. #12394

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Make Argent Open Source. #12394

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bf441e
made argent open source
hkey0 Mar 7, 2024
73283d8
add repo url
hkey0 Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/data/wallets/wallet-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ const walletData: WalletData[] = [
documentation: "",
},
{
last_updated: "June 22, 2022",
last_updated: "March 7, 2024",
name: "Argent",
image: ArgentImage,
brand_color: "#ffffff",
Expand All @@ -264,8 +264,8 @@ const walletData: WalletData[] = [
firefox: true,
chromium: true,
hardware: false,
open_source: false,
repo_url: "",
open_source: true,
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the open_source field has been correctly set to true, it's important to ensure that the repo_url field is updated with the URL of the open-source repository if available. This would provide users with direct access to the source code, enhancing transparency and trust.

Consider adding the repository URL to the repo_url field if the Argent wallet's source code is hosted on a public platform like GitHub.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks bot fixed it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hkey0, I've confirmed that the repo_url field for the Argent wallet entry has been updated with the URL of the open-source repository as you mentioned. This enhances the transparency and trust for users by providing direct access to the source code. Great job on making this update!

Analysis chain
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Extract the Argent wallet entry from the wallet-data.ts file to check the repo_url field
rg "name: \"Argent\"" -A 20 src/data/wallets/wallet-data.ts

Length of output: 624

If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!

repo_url: "https://github.com/argentlabs/argent-x",
non_custodial: true,
security_audit: [
"https://github.com/argentlabs/argent-contracts/tree/develop/audit",
Expand Down
Loading