Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Ethereum Ecosystem' CTA to ethereum.org #12373

Merged
merged 10 commits into from
Jun 24, 2024
Merged

Add 'Ethereum Ecosystem' CTA to ethereum.org #12373

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6273ae5
add CTA that links to Ethereum Ecosystem [Fixes #12372]
Maxservais Mar 5, 2024
e094f30
removing unused imports
Maxservais Mar 5, 2024
7e31f16
Merge branch 'dev' into add_CTA
Maxservais Mar 11, 2024
964358a
placing the CTA lower on the page
Maxservais Mar 11, 2024
2945fb8
Merge remote-tracking branch 'upstream/dev' into add_CTA
Maxservais Apr 8, 2024
5acf4fd
changing CTA from banner to button and adding disclaimer on hover tha…
Maxservais Apr 8, 2024
7e2c14b
changed CTA to text link with warning
Maxservais Apr 11, 2024
f07f461
Merge remote-tracking branch 'upstream/dev' into add_CTA
Maxservais May 13, 2024
cadad02
removed disclaimer and adapted styling
Maxservais May 13, 2024
47c5088
Merge branch 'dev' into add_CTA
wackerow Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/intl/en/page-dapps.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,5 +285,7 @@
"page-dapps-dapp-description-dodo": "DODO is a on-chain liquidity provider, which leverages the Proactive Market Maker algorithm (PMM)",
"page-dapps-dodo-image-alt": "DODO logo",
"page-dapps-dapp-description-artblocks": "Art Blocks is dedicated to bringing compelling works of contemporary generative art to life",
"page-dapps-artblocks-image-alt": "Art Blocks logo"
"page-dapps-artblocks-image-alt": "Art Blocks logo",
"page-dapps-explore-title": "Want to browse more apps?",
"page-dapps-explore": "Check out hundreds of dapps"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"page-dapps-explore": "Check out hundreds of dapps"
"page-dapps-explore": "Check out more dapps"

Dont have a strong opinion here, but think this would be better

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine either way here... "hundreds" does kinda drive home the point that there are a lot of them

}
24 changes: 23 additions & 1 deletion src/pages/dapps.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ import DocLink from "@/components/DocLink"
import Emoji from "@/components/Emoji"
import FeedbackCard from "@/components/FeedbackCard"
import GhostCard from "@/components/GhostCard"
import GlossaryTooltip from "@/components/Glossary/GlossaryTooltip"
import { Image } from "@/components/Image"
import InfoBanner from "@/components/InfoBanner"
import InlineLink, { BaseLink } from "@/components/Link"
Expand Down Expand Up @@ -121,6 +120,7 @@ import zerion from "@/public/dapps/zerion.png"
import developers from "@/public/developers-eth-blocks.png" // Handled inside Callout => height=200
import doge from "@/public/doge-computer.png" // HERO, full? 624px
import oneinch from "@/public/exchanges/1inch.png"
import exploring from "@/public/hackathon_transparent.png"
import magicians from "@/public/magicians.png"
import wallet from "@/public/wallet.png" // width=300

Expand Down Expand Up @@ -1550,6 +1550,16 @@ const DappsPage = () => {
/>
</RightColumn>
</TwoColumnContent>
<Box py={4} w="full">
<Text m={0} fontWeight="bold">
{t("page-dapps:page-dapps-explore-title")}
</Text>
<Text m={0}>
<InlineLink href="https://www.ethereum-ecosystem.com/apps">
{t("page-dapps:page-dapps-explore")}
</InlineLink>
</Text>
</Box>
<CalloutBanner
mt={32}
mx={0}
Expand Down Expand Up @@ -1766,6 +1776,18 @@ const DappsPage = () => {
</TwoColumnContent>
</Content>
)}
{selectedCategory !== CategoryType.FINANCE && (
<Content>
<Text m={0} fontWeight="bold">
{t("page-dapps:page-dapps-explore-title")}
</Text>
<Text m={0}>
<InlineLink href="https://www.ethereum-ecosystem.com/apps">
{t("page-dapps:page-dapps-explore")}
</InlineLink>
</Text>
</Content>
)}
{/* General content for all categories */}
<Content>
<CenterDivider />
Expand Down
Loading