Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update wallet-data #12257

Merged
merged 6 commits into from
Feb 21, 2024
Merged

chore: update wallet-data #12257

merged 6 commits into from
Feb 21, 2024

Conversation

nhsz
Copy link
Member

@nhsz nhsz commented Feb 21, 2024

This PR updates wallets data as defined by current find-wallet redesign, removing the following wallets:

  • Brave - not a wallet first software
  • MyCrypto - confusing
  • ShapeShift - not really a wallet anymore
  • Status - not a wallet anymore
  • web3Auth - not for end users

@nhsz nhsz self-assigned this Feb 21, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 21, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 79b127d
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65d619186c63dc0008f004d8
😎 Deploy Preview https://deploy-preview-12257--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nhsz nhsz mentioned this pull request Feb 21, 2024
Merged
@corwintines corwintines merged commit 62fec01 into dev Feb 21, 2024
6 checks passed
@corwintines corwintines deleted the update-wallet-data branch February 21, 2024 23:15
This was referenced Feb 28, 2024
Merged
Merged
@firebomb1 firebomb1 mentioned this pull request Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wackerow wackerow wackerow approved these changes

@corwintines corwintines corwintines approved these changes

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees

@nhsz nhsz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nhsz @corwintines @wackerow