Use header as H1 if title is missing in HubHero
#12254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minimalsm
requested review from
wackerow,
corwintines,
pettinarip and
nhsz
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@minimalsm I am not sure if it affects the design system directly; it's more of an SEO issue, no? For the DS might be an exception, not a big deal |
|
@nloureiro do we document what is H1 in design specs? |
Only the default style of an H1, targeting more MD pages. This case was a "false" H1 for SEO purposes. Not sure if the DS would have this level of detail. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a
titleis not passed in props, use theheaderas H1 instead.cc: @nloureiro this probably has design system considerations
Other
Small fix to error syntax
Related Issue
Fixes #12253
Related #12252