Fix OG page images #12234
Merged
Fix OG page images #12234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes metadata description not rendering appropriately
wackerow
requested review from
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
github-actions
bot
added
content 🖋️
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nhsz
reviewed
Feb 20, 2024
nhsz
reviewed
Feb 20, 2024
wackerow
commented
Feb 20, 2024
| description={t("common:page-dapps-desc")} | ||
| image={ogImage.src} | ||
| description={t("page-dapps-desc")} | ||
| image="/doge-computer.png" |
There was a problem hiding this comment.
We could, but figured it was a better approach to use the PageMetadata props for individual pages, and reserve the imageForSlug for whole markdown sections where we want to match part of the slug like /community/*... we don't have any nested /dapps/* pages
nhsz
reviewed
Feb 20, 2024
|
Awesome, thanks @nhsz! Will push a patch shortly |
corwintines
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactor: extract
getOgImageutil@/lib/utils/metadata.ts, including refactor of the default OG images into a data listimageForSlugfor easy updatingfeat: add/update page OG images
.srcto pass public path string directlyimageprop toPageMetadatafor pages that have hero images available to be used as OG imagefix: metadata string namespaces