-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] rename footer hyperlink #12139
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yash251 thanks, json key ("contact") should not be renamed, only value
actually I did not rename the key. I added
|
we should keep using the same key not a new one, when updating a translation, only values should be updated, not keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2024 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Hi @yash251, thanks again for contributing to ethereum.org! Besides GitPOAP, you're also eligible to claim an "onchain achievement token" (also known as "OAT") on Galxe 🏅 Here's how you can claim:
If you have any questions, don't hesitate to reach out to reply to this comment or reach out to me via ethereum.org's Discord server. Cheers! |
Description
fixes #12138
In the footer, renamed
Contact
intoPress Contact
, keeping the current mailto [[email protected]].