Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] rename footer hyperlink #12139

Merged
merged 2 commits into from
Feb 9, 2024
Merged

[fix] rename footer hyperlink #12139

merged 2 commits into from
Feb 9, 2024

Conversation

yash251
Copy link
Contributor

@yash251 yash251 commented Feb 9, 2024

Description

fixes #12138
In the footer, renamed Contact into Press Contact, keeping the current mailto [[email protected]].

Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 00613de
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65c65c2281123c0008f8887a
😎 Deploy Preview https://deploy-preview-12139--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added review needed 👀 translation 🌍 This is related to our Translation Program labels Feb 9, 2024
Copy link
Member

@nhsz nhsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yash251 thanks, json key ("contact") should not be renamed, only value

@yash251
Copy link
Contributor Author

yash251 commented Feb 9, 2024

@yash251 thanks, json key ("contact") should not be renamed, only value

actually I did not rename the key. I added press-contact as a new key.

contact key is still present

@nhsz
Copy link
Member

nhsz commented Feb 9, 2024

@yash251 thanks, json key ("contact") should not be renamed, only value

actually I did not rename the key. I added press-contact as a new key.

contact key is still present

we should keep using the same key not a new one, when updating a translation, only values should be updated, not keys

Copy link
Member

@nhsz nhsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nhsz nhsz merged commit 065f463 into ethereum:dev Feb 9, 2024
5 of 6 checks passed
Copy link

gitpoap-bot bot commented Feb 9, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

This was referenced Feb 14, 2024
@isabelladebrito
Copy link

Hi @yash251, thanks again for contributing to ethereum.org!

Besides GitPOAP, you're also eligible to claim an "onchain achievement token" (also known as "OAT") on Galxe 🏅

Here's how you can claim:

  1. Head over to https://galxe.com/ethereumorg/campaign/GCBctt4BkX
  2. We have already assigned you a role on ethereum.org's Discord server, from where you should be able to claim your OAT on Galxe
  3. Connect your wallet and Discord user
  4. Check the OAT(s) you're eligible to claim et voilà! 

If you have any questions, don't hesitate to reach out to reply to this comment or reach out to me via ethereum.org's Discord server. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename hyperlink text on website footer
3 participants