-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix table overflow #12128
Fix table overflow #12128
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@pettinarip it still does not seem to be fixed 🤔 |
@TylerAPfledderer thanks for testing. Could you double-check it? using incognito could be better, just to avoid any potential cache. I tested this on ios (safari and chrome), linux & win (chrome & brave) and it is working fine. LMK what OS and browser you are testing. |
So what I showed above is from Chrome on Android 14. Also breaking similarly in:
|
@TylerAPfledderer tested it using BrowserStack and it worked fine in a Samsung Galaxy S24, android 14, Chrome & FF. Its weird. I've also tested it in my personal android phone and worked too. Perhaps it is the browser version? 🤔 Im using Chrome v121.0.6167.164 |
@pettinarip Yeah, I am seeing the same thing as @TylerAPfledderer... both on iOS (Brave and Safari), and Android (Chrome... technically Vanadium)... and also when mocking mobile sizes using a desktop browser. The horizontal scroll only goes away if I remove the table entirely, otherwise it's definitely persisting for me. |
@wackerow wow, this is even weirder haha I've tested it on my personal phone (android), on a physical iphone, on different laptops, and they all work fine for me! what is going on! xD Are we all using the correct preview deploy? it is https://deploy-preview-12128--ethereumorg.netlify.app/developers/docs/evm/opcodes |
@pettinarip actually look at this page: |
Yeah, +1 to @TylerAPfledderer... @pettinarip I am not having issues with the opcodes page, but I am getting horizontal scroll on the energy consumption page (caused by the table) |
Aha! @TylerAPfledderer @wackerow I missed that case! 🙃 for some reason I always thought you were testing the opcodes page haha...my bad. Ok! I've set a width to one of the containers that were used in the Static layout and that should fix the issue. |
Good with me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed for me now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great! Thanks @pettinarip!
Description
Adds relative position to the table container to avoid overflows.
Related Issue