-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nav menu - redesign implementation #12125
Conversation
clean up icon/button components, including HamburgerButton and CloseButton
close mobile menu by clicking outside of drawer
scrolls container to end when third level opens on tablet size devices
removes stray ms={2} from Static layout content
Flipped this to "ready for review" but please do not merge until translated strings are imported, which is the last blocking todo. |
[bug] @wackerow, I think this spacing is too big. There is an extra margin that leaves the navigation too far out for the glyph |
@wackerow, there are two bugs in the menu's interactivity. We can chat about it if it needs more details.
solution: add the condition: if open && hover { disable the close option }
Solution????: make the button go all the way to the bottom part of the header, with an inside tag that is the size of the actual button to create balance visually, but the interaction keeps the menu open (not sure it makes sense, open to discuss other solutions ) |
@wackerow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀 🚀
Locales: am, ca, fi, fil, gl, he, hi, hr, ka, km, kn, ko, ml, ml, mr, ms, nb, nl, pcm, pt, pt-br, ro, ru, se, sk, sl, sr, sw, ta, th, tr, uk, ur, vi
Locales: am, hy-am, be, bs, da, gu, ig, lt, pcm, fa, ta, tk, uz
Locales: ar, az, bg, bn, cs, de, el, es, fr, hu, id, it, ja, kk, ne-np, pl, zh, zh-tw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a couple of comments on some spelling, but this looks good otherwise to me! Nice work!
Co-authored-by: Corwin Smith <[email protected]>
Description
Implements the newly redesigned navigation menu for both desktop and mobile, including changes to the information architecture
useNav
hook with new menu item structure, updated labels and addition of item descriptions/subtext.Desktop
NavigationMenu
componentMobile
Accordion
componentPreview link
Related issue
TODO