Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import final updates from Next.js repo fork #11924

Merged
merged 32 commits into from
Jan 15, 2024
Merged

Import final updates from Next.js repo fork #11924

merged 32 commits into from
Jan 15, 2024

Conversation

wackerow
Copy link
Member

wackerow and others added 30 commits January 5, 2024 15:53
@wackerow
fix: modal close button positioning for rtl/ltr
ef1863e
@wackerow
refactor: update CodeModal for Next.js conventions
5d0e427
@wackerow
style: fix TitleCardList position and hover color
3125728 
use direction-responsive margin, apply black hover text color to all child text (fixes contrast ratio on dark mode hovering)
@wackerow
fix: direction-responsive margins and padding
1ceed77
@wackerow
fix: direction responsive arrow on tutorials
fb4a89b
@wackerow
fix: use absolute path to see if namespace exists
45fa5c2
@wackerow
fix: broken front matter image paths
a782b1f
@corwintines
adjust roadmap header image height to match production
e3235a2
@wackerow
build: yarn add -D plaiceholder
87de30e
@wackerow
feat: use blur placeholder for all internal images
932ea41
@corwintines
add primary namespace functionality for existsNamespace check consist…
80bd510 
…ency
@nhsz
Merge branch 'dev' into roadmapHeader
11ed80c
@wackerow
chore: use constant, reorder ns assignment
b701a90
@wackerow
refactor: rehypeImg to cache base64 placeholders
91bb415
@wackerow
[chore] commit placeholder data json files
8baa192
@wackerow
refactor: extract placeholder image dir as const
365ea1a
@pettinarip
Merge pull request #271 from ethereum/content-not-translated-patch
e277ff8 
Fix: Use absolute path to check if intl namespace exists
@wackerow
chore: rm existing placeholder folder structure
1fdb015
@wackerow
refactor: use consistent blurDataURL property name
2a2a585 
removing "imageBlurData"
@wackerow
feat: add getHashFromBuffer crypto utility
ba7714c
@wackerow
feat: fix setImagePlaceholders and implement hash
5d743c2 
Implements a hash fingerprint for each image placeholder, to ensure the blurDataURL being obtained is from the exact same image data. Adds await to setImagePlaceholders function call, fixing markdown images not receiving blur data. Restructures cache data to use kebab-cased JSON files instead of nested directories.
@wackerow
chore: commit base64 image placeholder data
6b837b8
@wackerow
fix: check both blurDataURL locations within props
39bdac5 
Fixes frontmatter image blur data being ignored
@wackerow
Merge branch 'dev' into blur
017505b
@wackerow
chore: clean up rehypeImg, add comments
38ba6f9
@wackerow
refactor: use boolean flag over structuredCone
337e2a8
@wackerow
refactor: use size 16 with getPlaiceholder
28f4f1c 
only applies to markdown images
@wackerow
chore: commit base64 image placeholder data
970af49
@pettinarip
Merge pull request #268 from ethereum/dir-responsive
e2c0747 
Fix: direction-responsive margins and padding
@pettinarip
Merge pull request #266 from ethereum/patch-code-modal
3182b3a 
Patch CodeModal and TitleCardList
pettinarip and others added 2 commits January 12, 2024 17:15
@pettinarip
Merge pull request #272 from ethereum/roadmapHeader
1092f75 
adjust roadmap header image height to match production
@wackerow
Merge pull request #273 from ethereum/blur
7b13ae0 
Implement blurred image placeholders
@netlify Netlify
Copy link

netlify bot commented Jan 12, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 7b13ae0
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65a1c46431c2cd0007f3870a
😎 Deploy Preview https://deploy-preview-11924--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies review needed 👀 tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Jan 12, 2024
@nhsz nhsz merged commit eea1090 into ethereum:dev Jan 15, 2024
This was referenced Jan 17, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhsz nhsz nhsz approved these changes

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wackerow @nhsz @corwintines @pettinarip