-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(StakingProductsCardGrid): update types, logic, and UI composition #11477
refactor(StakingProductsCardGrid): update types, logic, and UI composition #11477
Conversation
❌ ethereum-org-website-dev deploy preview failedYour build failed. View the build logs. Errors Your plugins must export known APIs from their gatsby-node. See https://www.gatsbyjs.com/docs/reference/config-files/gatsby-node/ for the list of Gatsby node APIs. - The plugin [email protected] is using the API "unstable_shouldOnCreateNode" which is not a known API. Some of the following may help fix the error(s): - Rename "unstable_shouldOnCreateNode" -> "shouldOnCreateNode" Your plugins must export known APIs from their gatsby-node. See https://www.gatsbyjs.com/docs/reference/config-files/gatsby-node/ for the list of Gatsby node APIs. - The plugin [email protected] is using the API "unstable_shouldOnCreateNode" which is not a known API. Some of the following may help fix the error(s): - Rename "unstable_shouldOnCreateNode" -> "shouldOnCreateNode" |
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @TylerAPfledderer, thanks! Much cleaner. Working well for me and think we can pull this in.
Left a question on StakingProductCard.tsx
, but that doesn't have to block this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth breaking this component apart as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wackerow Hmm I'm not sure. If I continue to break it down, I guess it would be making it's own useHook to abstract away the data and logic. I don't see the usefulness in splitting up the component structure; to me it's not big enough.
I don't think there is enough there right now to justify it unless there becomes an issue in readability.
Description
This PR overhauls the structure of
StakingProductsCardGrid
.stakingProducts
json dataRelated Issue
N/A