-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update Storybook docs and usage #11324
refactor: update Storybook docs and usage #11324
Conversation
✅ ethereum-org-website-dev deploy preview ready
|
…j-docs-and-unification
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…roj-docs-and-unification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TylerAPfledderer For my own understanding, is there any need/benefit to match the text in these stories (ie a label, or children text) to the text found in the Figma DS components?
This otherwise looks good to me! Thanks so much for cleaning this up... gonna add one commit to capitalize "Figma", but otherwise think we can pull this in. 💪
…j-docs-and-unification
@wackerow I would argue that doing this would make it helpful for Nuno with consistency in verifying the design has been implemented to code as intended. Applying some other content may bring out an edge case or an underlying bug with widths or spacing, but also using the content from Figma would provide a true baseline in the conversion to the Storybook visual testing environment. Side note: "consistency" seems to be the unfortunate buzzword for me 🤣 |
Merged... thanks @TylerAPfledderer! I agree that we should strive to match the text to Figma where possible, especially on the base components. Can address that separate from this. |
Description
This PR updates the
applying-storybook
docs to match the latest usage of Storybook, and updates existing stories to match said usage.This PR recognizes that these docs and approach to using storybook for the project might be considered fluid as implementation of the new DS still continues, and further contributions from the community can alter the approach in the future for improved DX.
Related Issue
N/A