Remove Matomo tracking pixel #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing the
vuepress-plugin-ipfsappears to have created some havoc in our HTML builds when interacting with the Matomo tracking pixel.Before adding it:
view-source:https://5e82199f98b4cc0007b721be--ethereumorg.netlify.app/After adding it:
view-source:https://5e87b5c66f385800079a016c--ethereumorg.netlify.app/This resulted in the pixel (& other scripts) being injected into the
<body>vs. the<head>of the HTML. Our reported site traffic basically doubled as a result (visits were being double-counted), all reported as direct entry (as the pixel can't attribute source channel).This PR removes the Matomo tracking pixel, which resolves the conflict with
vuepress-plugin-ipfs. The tracking pixel ultimately didn't provide much value anyway, merely providing a back up in case a browser had JS disabled.Related Issue
None
Screenshots (if appropriate):