Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overflow on a dev doc is breaking on small screens #14013

Closed
1 of 2 tasks
nloureiro opened this issue Oct 1, 2024 · 9 comments
Closed
1 of 2 tasks

overflow on a dev doc is breaking on small screens #14013

nloureiro opened this issue Oct 1, 2024 · 9 comments
Assignees
Labels
bug 🐛 Something isn't working hacktoberfest Track hacktoberfest activity

Comments

@nloureiro
Copy link
Contributor

Describe the bug

on small screens, this page is broken because of an overflow fail

https://ethereum.org/en/developers/docs/consensus-mechanisms/pow/

Screen Shot 2024-10-01 11 22 43 AM

To reproduce

  1. Go to en/developers/docs/consensus-mechanisms/pow/#finality

  2. resize the window to a smaller than 500px

  3. See the page with horizontal scroll

Expected behavior

should not have horizontal scroll

Screenshots

No response

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@nloureiro nloureiro added the bug 🐛 Something isn't working label Oct 1, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Oct 1, 2024
@0xdavinci
Copy link

overflow_issue

@jorgezerpa
Copy link

Hi! Can I be assigned to this one? 🤠

@nloureiro nloureiro removed the needs triage 📥 This issue needs triaged before being worked on label Oct 2, 2024
@nloureiro
Copy link
Contributor Author

Hi! Can I be assigned to this one? 🤠

It's yours, thank you!

@isabelladebrito isabelladebrito added the hacktoberfest Track hacktoberfest activity label Oct 2, 2024
@jorgezerpa
Copy link

hello! @nloureiro

the idea is to break the word into more lines (like image below) or let an scroll on the list element as sugested here ?

image

@nloureiro
Copy link
Contributor Author

hello! @nloureiro

the idea is to break the word into more lines (like image below) or let an scroll on the list element as sugested here ?

image

yes, I think breaking into multiple lines makes sense here; it's not a code snippet.

The screenshot looks great to me.

@jorgezerpa
Copy link

jorgezerpa commented Oct 2, 2024

@nloureiro Nice! I think this is ready to make a PR
but before, should I have to implement this changes into the translations pages too?

image

@nloureiro
Copy link
Contributor Author

@nloureiro Nice! I think this is ready to make a PR but before, should I have to implement this changes into the translations pages too?

image

Good question, @wackerow should this be done on all translated pages?

jorgezerpa added a commit to jorgezerpa/ethereum-org-website that referenced this issue Oct 2, 2024
…reens to avoid overflow on the layout and horizontal scroll
@jorgezerpa
Copy link

@nloureiro I checked other languages pages and found the same issue, So I fix on those files to.

PR opened, I'm attentive for corrections if its needed🤠

jorgezerpa added a commit to jorgezerpa/ethereum-org-website that referenced this issue Oct 3, 2024
…ong-ethereum-address' with tailwind class 'break-words'
@corwintines
Copy link
Member

Thanks @jorgezerpa

There was a more global solution that was merged with #14050, so going to close this out as complete. Feel free to take a look at what was brought in :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working hacktoberfest Track hacktoberfest activity
Projects
None yet
Development

No branches or pull requests

5 participants