Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create story for MergeInfoGraphic #13242

Closed
2 tasks
Tracked by #13043
corwintines opened this issue Jun 25, 2024 · 4 comments
Closed
2 tasks
Tracked by #13043

Create story for MergeInfoGraphic #13242

corwintines opened this issue Jun 25, 2024 · 4 comments
Assignees
@Baystef
Labels
dev required This requires developer resources Status: Stale This issue is stale because it has been open 30 days with no activity. testing

Comments

@corwintines
Copy link
Member

corwintines commented Jun 25, 2024 •
edited
Loading

Create story tests for MergeInfoGraphic component

Prerequisite

To get yourself up to speed on how we use storybook on ethereum.org, learn more here

What to do

  • Create story file /src/components/MergeInfoGraphic/MergeInfoGraphic.stories.tsx
  • Write story testing render of the MergeInfoGraphic component in context of use

The MergeInfoGraphic is used on the /roadmap/merge page. You can find the file its used in for context here.
@corwintines corwintines mentioned this issue Jun 25, 2024
Open
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Jun 25, 2024
@corwintines corwintines changed the title MergeInfoGraphic Create story for MergeInfoGraphic Jun 25, 2024
@corwintines
Copy link
Member Author

@Baystef I have created this issue for the MergeInfoGraphic. If you don't mind commenting in here, I can assign to you :)

@Baystef
Copy link
Contributor

Baystef commented Jun 25, 2024

Hi @corwintines , I'll love to be assigned this. Thanks 🙂

@corwintines corwintines added dev required This requires developer resources testing and removed needs triage 📥 This issue needs triaged before being worked on labels Jun 25, 2024
@corwintines
Copy link
Member Author

Great, assigned to you @Baystef!

@Baystef Baystef mentioned this issue Jun 27, 2024
Merged
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jul 26, 2024
corwintines added a commit that referenced this issue Aug 6, 2024
@corwintines
Merge pull request #13262 from Baystef/feat/mergeinfographic-story
596e24c 
Create story tests for MergeInfoGraphic component [#13242]
This was referenced Aug 7, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Baystef Baystef

Labels
dev required This requires developer resources Status: Stale This issue is stale because it has been open 30 days with no activity. testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@corwintines @Baystef