Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the footer navigation #12376

Closed
2 tasks
nloureiro opened this issue Mar 5, 2024 · 8 comments · Fixed by #12396 or #12437
Closed
2 tasks

Change the footer navigation #12376

nloureiro opened this issue Mar 5, 2024 · 8 comments · Fixed by #12396 or #12437
Labels
design required 🎨 This involves design changes dev required This requires developer resources feature ✨ This is enhancing something existing or creating something new medium priority This has a medium priority

Comments

@nloureiro
Copy link
Contributor

Is your feature request related to a problem? Please describe.

With the new Header Navigation in production, we want to explore the change on the footer.
It does not need to have the same information architecture, but it should be updated.

Describe the solution you'd like

A new navigation on the footer

Describe alternatives you've considered

as many as possible

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@nloureiro nloureiro added the feature ✨ This is enhancing something existing or creating something new label Mar 5, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Mar 5, 2024
@Satglow
Copy link

Satglow commented Mar 5, 2024

ethereum org footer proposal

  • I have followed the header menu, including the lowest level of the hierarchy where it is useful to the user to see it (e.g. Emerging use cases), but including the middle hierarchy element if the summary expression is enough to navigate (e.g. staking) or the lowest level is too detailed (e.g. how to guide examples).
  • Called the overview item as home (Documentation home), or kept as hub if it was already in the list with this expression (Learn Hub), we can use one of them for all place.
  • Regarding the Enterpise under Build, I thought it is more meaningful if using both hierarchy levels (Enterprise - Mainnet Ethereum) instead of listing Mainnet Ethereum and Private Ethereum without much context.
  • I kept the already added items like EF, EF blog, ESP etc. I am not aware of any more relevant for this topic.
  • Added a "General" tab, including Brand assets from Ecosystem, Glossary from Learn, Code of conduct as new potential and relevant item, and kept the rest from About ethereum.org list.

@nloureiro
Copy link
Contributor Author

Thank you.

I created a Figma file to test it on top of the Footer we have for the design system > feel free to edit and comment
https://www.figma.com/file/cKWwsQVF762HM7IuSnH8xn/Footer-links-update?type=design&node-id=1%3A48&mode=design&t=T8aolwB1Rvv4mbHi-1
Screen Shot 2024-03-06 10 42 55 AM

My first reaction is that it can be too many columns. I tried to remove one, but even so... might be too much

Screen Shot 2024-03-06 10 43 02 AM

maybe add a dipper level like the header? accordion like the mobile menu? or curate some of the links and make the list smaller

@Satglow
Copy link

Satglow commented Mar 6, 2024

Thanks, this is a great visualization. I didn't know that the previous version was not good, so I shouldn't simulate that with new content. I have curated the list to try with a shorter version.

ethereum org footer proposal v2

If it is workable, for example we can call Learn hub based on the main content that we find there = What is Ethereum, ETH & web3? Maybe a bit long, but 1 row instead of 4. (What is Ethereum & ETH? also a good version) Same for Community hub = Online communities & events

We could maybe merge the columns like Learn & Use, Build & Research, Participate (also with the items from General). One option is 3 columns with long list, or again a shorter curated list like below.

ethereum org footer proposal v3

@iusx
Copy link
Contributor

iusx commented Mar 7, 2024

CleanShot 2024-03-07 at 15 41 12

Hey! I noticed there is a YouTube icon in your prototype, so I added a YouTube link and a new Twitter icon in pull request #12382. If you or the team do not plan to update the Twitter icon, I can remove it, leaving only the YouTube icon.

Thank you.

I created a Figma file to test it on top of the Footer we have for the design system > feel free to edit and comment https://www.figma.com/file/cKWwsQVF762HM7IuSnH8xn/Footer-links-update?type=design&node-id=1%3A48&mode=design&t=T8aolwB1Rvv4mbHi-1 Screen Shot 2024-03-06 10 42 55 AM

My first reaction is that it can be too many columns. I tried to remove one, but even so... might be too much

Screen Shot 2024-03-06 10 43 02 AM

maybe add a dipper level like the header? accordion like the mobile menu? or curate some of the links and make the list smaller

@nloureiro
Copy link
Contributor Author

CleanShot 2024-03-07 at 15 41 12

Hey! I noticed there is a YouTube icon in your prototype, so I added a YouTube link and a new Twitter icon in pull request #12382. If you or the team do not plan to update the Twitter icon, I can remove it, leaving only the YouTube icon.

Thank you.
I created a Figma file to test it on top of the Footer we have for the design system > feel free to edit and comment https://www.figma.com/file/cKWwsQVF762HM7IuSnH8xn/Footer-links-update?type=design&node-id=1%3A48&mode=design&t=T8aolwB1Rvv4mbHi-1 Screen Shot 2024-03-06 10 42 55 AM
My first reaction is that it can be too many columns. I tried to remove one, but even so... might be too much
Screen Shot 2024-03-06 10 43 02 AM
maybe add a dipper level like the header? accordion like the mobile menu? or curate some of the links and make the list smaller

Oh, you just found a bug on the design system, the YouTube icon was removed last year, and I did not update the Figma file, my bad, sorry about this (was this PR #10775)
Can you roll back on your PR? I will change on the DS, too, and add the X icon.

@iusx
Copy link
Contributor

iusx commented Mar 7, 2024

CleanShot 2024-03-07 at 15 41 12
Hey! I noticed there is a YouTube icon in your prototype, so I added a YouTube link and a new Twitter icon in pull request #12382. If you or the team do not plan to update the Twitter icon, I can remove it, leaving only the YouTube icon.

Thank you.
I created a Figma file to test it on top of the Footer we have for the design system > feel free to edit and comment https://www.figma.com/file/cKWwsQVF762HM7IuSnH8xn/Footer-links-update?type=design&node-id=1%3A48&mode=design&t=T8aolwB1Rvv4mbHi-1 Screen Shot 2024-03-06 10 42 55 AM
My first reaction is that it can be too many columns. I tried to remove one, but even so... might be too much
Screen Shot 2024-03-06 10 43 02 AM
maybe add a dipper level like the header? accordion like the mobile menu? or curate some of the links and make the list smaller

Oh, you just found a bug on the design system, the YouTube icon was removed last year, and I did not update the Figma file, my bad, sorry about this (was this PR #10775) Can you roll back on your PR? I will change on the DS, too, and add the X icon.

I'm really sorry. I can directly modify and remove the YouTube icon in the pull request, leaving only a Twitter x icon. You can check it in #12382.

@nloureiro
Copy link
Contributor Author

Thanks, this is a great visualization. I didn't know that the previous version was not good, so I shouldn't simulate that with new content. I have curated the list to try with a shorter version.

ethereum org footer proposal v2

If it is workable, for example we can call Learn hub based on the main content that we find there = What is Ethereum, ETH & web3? Maybe a bit long, but 1 row instead of 4. (What is Ethereum & ETH? also a good version) Same for Community hub = Online communities & events

We could maybe merge the columns like Learn & Use, Build & Research, Participate (also with the items from General). One option is 3 columns with long list, or again a shorter curated list like below.

ethereum org footer proposal v3

Thank you for the second version, but I think it makes harder to understand

I did some explorations on figma, but I got to a point that the quick win here is your first proposal with minor design adjustments.

  • change some spacing
  • different braskdown for smaller screens
  • add a footer to the footer for the links that ar enot on the top menu and can be consider secundary

@Satglow let me know what do think on figma > https://www.figma.com/file/cKWwsQVF762HM7IuSnH8xn/Footer-links-update?type=design&node-id=4%3A43546&mode=design&t=rReoPKKv7zMDOBfh-1

@wackerow what do think, is it fast to build a PR with is to test on the browser?

@Satglow
Copy link

Satglow commented Mar 7, 2024

Thanks a lot, I am okey with that! The shorter list still can work without merging the items, if you are looking for less item. Like this:

ethereum org footer proposal v4

I think the 'secondary' is great as footer of footer, just we should not leave out, because this is not available elsewhere - i think this is one of the main purpose of the footer part.

@wackerow wackerow added design required 🎨 This involves design changes medium priority This has a medium priority dev required This requires developer resources and removed needs triage 📥 This issue needs triaged before being worked on labels Mar 9, 2024
corwintines added a commit that referenced this issue Mar 13, 2024
Footer navigation update [Closes #11955, Closes #12376]
This was referenced Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design required 🎨 This involves design changes dev required This requires developer resources feature ✨ This is enhancing something existing or creating something new medium priority This has a medium priority
Projects
None yet
4 participants