Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: social button sizing #12213

Closed
1 of 2 tasks
wackerow opened this issue Feb 16, 2024 · 1 comment · Fixed by #12223
Closed
1 of 2 tasks

Bug report: social button sizing #12213

wackerow opened this issue Feb 16, 2024 · 1 comment · Fixed by #12223
Assignees
Labels
bug 🐛 Something isn't working dev required This requires developer resources low priority This has a low priority

Comments

@wackerow
Copy link
Member

wackerow commented Feb 16, 2024

Describe the bug

The bottom of every page contains social links/icons in the Footer. Tabbing over these shows a strange shape for the outline of the buttons as a result of mixed sizing between the anchor link and contained SVG.

To reproduce

  1. Go to https://ethereum.org or any subpage
  2. Scroll to bottom and find GitHub/Twitter/Discord icons
  3. Click just before the set of icons to move keyboard focus, then hit "Tab" to highlight one of the icons

(Or, use keyboard to tab all the way down to these elements from the top)

Expected behavior

Outline shown for the button should simply be square-shaped (with rounded corners)

Screenshots

image

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

We seem to be using BaseLink for these, but given there is no text, I think a more appropriate component would probably be our IconButton component. These should remain proper anchor links, but stylistically feel like buttons. Aria-label must be maintained.

Would you like to work on this issue?

  • Yes
  • No
@wackerow wackerow added bug 🐛 Something isn't working low priority This has a low priority dev required This requires developer resources labels Feb 16, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Feb 16, 2024
@wackerow wackerow removed the needs triage 📥 This issue needs triaged before being worked on label Feb 16, 2024
@AjayiMike
Copy link
Contributor

Hey @wackerow, may I be assigned this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working dev required This requires developer resources low priority This has a low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants