Make solidity-match-variable-decls regexp's unhighlited matches shy. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that if the two optional matches in the regexp, `\\[ *[0-9]*\\]` or `(regexp-opt solidity-variable-modifier 'words)` have no match, the name of the variable being declared can be still be found via the absolute match index 2. Prior to this change, a simple `address foo` would match the regexp, but the expected match index for the variable, 4, would have no match, which could lead to font-lock errors in some circumstances. [Reference for shy matches]( https://www.gnu.org/software/emacs/manual/html_node/emacs/Regexp-Backslash.html#index-shy-group_002c-in-regexp-1000)
|
Hey @coventry very nice catch. Thank you! |
|
NP, glad I could help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that if the two optional matches in the regexp,
\\[ *[0-9]*\\]or(regexp-opt solidity-variable-modifier 'words)have no match, the name of thevariable being declared can be still be found via the absolute match index 2.
Prior to this change, a simple
address foowould match the regexp, but theexpected match index for the variable, 4, would have no match, which could lead
to font-lock errors in some circumstances.
Reference for shy matches
Fixes #47