Define sha256 & blake3 spec functions - #5555
Merged
Merged
Conversation
Contributor
|
Could we have |
Member
Author
Yes, will do! I was very much on the fence about this 😄 |
jtraglia
changed the title
sha256_hash & blake3_hash functionssha256 & blake3 spec functions
0xsamalt
added a commit
to 0xsamalt/consensus-specs
that referenced
this pull request
Aug 24, 2026
Builtin hash is no longer shadowed in the compiled spec namespace after ethereum#5555, so the dataclass-generated hash can be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
hashfunction in Python is overloaded to be the SHA256 hash. Now that there are two hash functions (BLAKE3 was introduced in EIP-8321), we should make this explicit. Also, I never liked that these were defined internally instead of in the markdown files.