Use the genesis root as a dependent root for the first two epochs - #5515
Merged
jihoonsong merged 2 commits intoAug 5, 2026
Merged
Conversation
jihoonsong
requested review from
jtraglia,
mkalinin and
nflaig
and removed request for
jtraglia and
mkalinin
August 5, 2026 08:41
jihoonsong
changed the title
jihoonsong
force-pushed
the
get-shuffling-dependent-root-genesis
branch
from
August 5, 2026 08:49
cacba95 to
dbe88cd
Compare
lodekeeper
approved these changes
Aug 5, 2026
lodekeeper
left a comment
lodekeeper
left a comment
There was a problem hiding this comment.
Matches Lodestar's implementation: near genesis, dependent roots resolve to the genesis block root rather than zero-root.
Contributor
|
LGTM |
jtraglia
reviewed
Aug 5, 2026
jtraglia
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
get_shuffling_dependent_rootreturned Root(), which causes some discrepancy between the spec and clients. The genesis block is the dependent block for the first two epochs and it seems all CL clients but Grandine use the genesis block root as a dependent root for the first two epochs. This PR modifiesget_shuffling_dependent_rootto return the genesis block root for epoch <= MIN_SEED_LOOKAHEAD.