Skip to content

Compute real aggregate pubkeys when BLS verification is disabled #5489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtraglia merged 3 commits into from
Jul 29, 2026
Merged

Compute real aggregate pubkeys when BLS verification is disabled #5489

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a7d7b5
Compute real aggregate pubkeys when BLS verification is disabled
nazarhussain Jul 28, 2026
ebd58d3
Update the doc comments to explain the reasoning better
nazarhussain Jul 28, 2026
4b921fe
Merge branch 'master' into nh/bls-real-aggregate-pubkeys
jtraglia Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/core/pyspec/eth_consensus_specs/utils/bls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,10 @@ def Sign(SK, message):
return signature_point.to_compressed_bytes()


@only_with_bls(alt_return=STUB_PUBKEY)
# Pubkey aggregation must be computed even when BLS is inactive: unlike
# signature verification, its result is data written into the beacon state
# (e.g. `next_sync_committee.aggregate_pubkey`), which clients must be able
# to reproduce regardless of the `bls_setting` in use.
def AggregatePKs(pubkeys):
aggregate = _aggregate_pubkey_points(pubkeys)
assert aggregate is not None, f"empty or invalid pubkeys: {pubkeys!r}"
Expand Down