Ensure confirmed chain includes greatest unrealized checkpoint - #5288
Merged
Conversation
jtraglia
changed the title
jtraglia
changed the title
Contributor
|
Tests (based on v1.7.0-alpha.8):
|
tersec
pushed a commit
to status-im/nimbus-eth2
that referenced
this pull request
May 26, 2026
The spec was updated to match our implementation, the current epoch GU has to not be just any ancestor but actually be the expected checkpoint. - ethereum/consensus-specs#5288
Member
|
Hey @mkalinin I support this change. Will approve/merge after the conflict is resolved. |
Contributor
Author
done! |
nazarhussain
added a commit
to ChainSafe/lodestar
that referenced
this pull request
Jun 3, 2026
michaelsproul
added a commit
to dapplion/lighthouse
that referenced
this pull request
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes reconfirmation code from checking that a confirmed block is descendant of
block(GU)to checking that a confirmed block is a descendant ofGU, i.e. that the checkpoint is in the chain of a confirmed block.This PR comes with the corresponding test.