Repository navigation
Move safe-block.md definitions to fast-confirmation.md #5278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ca5200a
Move safe-block.md to fast-confirmation.md
mkalinin 0ee6183
Update fast-confirmation.md
mkalinin f4635b4
Apply suggestions by @jtraglia
mkalinin 41e827c
Apply suggestions from code review
mkalinin 5700a20
Apply suggestion from @jtraglia
mkalinin 549b62a
Fix lint
mkalinin bff7356
Polish Gloas modification
mkalinin 4c09c2e
Fix notes
jtraglia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # Bellatrix -- Fast Confirmation | ||
|
|
||
| <!-- mdformat-toc start --slug=github --no-anchors --maxlevel=6 --minlevel=2 --> | ||
|
|
||
| - [Introduction](#introduction) | ||
| - [Safe execution block](#safe-execution-block) | ||
| - [`get_safe_execution_block_hash`](#get_safe_execution_block_hash) | ||
|
|
||
| <!-- mdformat-toc end --> | ||
|
|
||
| ## Introduction | ||
|
|
||
| This is the modification of the fast confirmation accompanying Bellatrix. | ||
|
|
||
| ## Safe execution block | ||
|
|
||
| With Bellatrix introducing execution payload, `get_safe_execution_block_hash` | ||
| function is introduced. This function returns the block hash of the payload | ||
| included into the most recent confirmed block. This block hash is communicated | ||
| to ExecutionEngine as a hash of a safe block. | ||
|
|
||
| ### `get_safe_execution_block_hash` | ||
|
mkalinin marked this conversation as resolved.
Outdated
|
||
|
|
||
| ```python | ||
| def get_safe_execution_block_hash(fcr_store: FastConfirmationStore) -> Hash32: | ||
| safe_block = fcr_store.store.blocks[fcr_store.confirmed_root] | ||
| return safe_block.body.execution_payload.block_hash | ||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # Gloas -- Fast Confirmation | ||
|
|
||
| <!-- mdformat-toc start --slug=github --no-anchors --maxlevel=6 --minlevel=2 --> | ||
|
|
||
| - [Introduction](#introduction) | ||
| - [Safe execution block](#safe-execution-block) | ||
| - [`get_safe_execution_block_hash`](#get_safe_execution_block_hash) | ||
|
|
||
| <!-- mdformat-toc end --> | ||
|
|
||
| ## Introduction | ||
|
|
||
| This is the modification of the fast confirmation accompanying Bellatrix. | ||
|
jtraglia marked this conversation as resolved.
Outdated
|
||
|
|
||
| ## Safe execution block | ||
|
|
||
| ### `get_safe_execution_block_hash` | ||
|
mkalinin marked this conversation as resolved.
Outdated
|
||
|
|
||
| *Note:* Starting with Gloas only the parent payload of a confirmed beacon block | ||
| can be deemed safe. | ||
|
mkalinin marked this conversation as resolved.
Outdated
|
||
|
|
||
| ```python | ||
| def get_safe_execution_block_hash(fcr_store: FastConfirmationStore) -> Hash32: | ||
| safe_block = fcr_store.store.blocks[fcr_store.confirmed_root] | ||
| # [Modified in Gloas:EIP7732] | ||
| safe_block_bid = safe_block.body.signed_execution_payload_bid.message | ||
| return safe_block_bid.parent_block_hash | ||
|
mkalinin marked this conversation as resolved.
Outdated
|
||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.