Move safe-block into specs directory - #5237
Closed
jtraglia wants to merge 1 commit into
Closed
Conversation
Contributor
|
What do you think about making |
Member
Author
Yes, I think that makes even more sense! I'm going to close this and let you handle that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the fork-choice safe-block specs into the
specsdirectory. I believe this is a better spot for it, especially since it's versioned. I changed the parameter type fromStoretoFastConfirmationStoreso we have direct access to theconfirmed_rootfield and do not need an abstract helper.cc @mkalinin.