Add note about validating deposit signatures before the fork - #5227
Merged
jtraglia merged 2 commits intoMay 15, 2026
Conversation
Member
Author
|
It's hard to get reviews for this apparently. I'm going to make an executive decision to merge this. It might not be truly necessary but I think it's good to mention just in case there is an attacker which does this. |
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While thinking about deposit signature validation concerns (ie #5223), I realized that there could be a lot of new/unique builder deposits at the fork. All of these signatures would be validated during the upgrade. Say an attacker decided to make 20 thousand 1 ETH deposits in the epoch before the fork. If this takes longer than 12 seconds to verify, nodes will temporarily fall behind. Clients should try to validate these signatures before the upgrade, when there are spare resources.