Remove pre-capella check in BTEC gossip handler - #5205
Closed
jtraglia wants to merge 1 commit into
Closed
Conversation
rolfyone
approved these changes
May 4, 2026
nflaig
approved these changes
May 5, 2026
nflaig
requested changes
May 13, 2026
nflaig
left a comment
nflaig
left a comment
Member
There was a problem hiding this comment.
I believe this can be handled in the test harness in clients or how spec tests are generated, while it's true we don't need this pre-capella check anymore, we might have a similar case in the future and this serves as a good precedent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the interop, I talked with clients about networking tests and there were complications with the
BLSToExecutionChangegossip validation tests. Unlike other handlers, this handler checks that the current epoch is post-capella. This is annoying to test since the tests do not use realistic epochs. IIRC, this check exists because there were concerns that there would be a fight for inclusion between hackers and victims; see #3206 for more information. This concern is no longer relevant and it would be easier to just remove the check.