Distinguish absent PTC votes from negative votes - #5180
Merged
Conversation
ensi321
approved these changes
Apr 28, 2026
nflaig
reviewed
Apr 28, 2026
Co-authored-by: Nico Flaig <nflaig@protonmail.com>
nflaig
approved these changes
Apr 29, 2026
jtraglia
changed the title
potuz
approved these changes
Apr 29, 2026
etan-status
approved these changes
Apr 29, 2026
etan-status
left a comment
etan-status
left a comment
Contributor
There was a problem hiding this comment.
The conditions are still the same, this seems to be a pure preparation for some future PR without any semantic change. fine for me.
rolfyone
approved these changes
Apr 29, 2026
23 tasks
3 tasks
jtraglia
pushed a commit
that referenced
this pull request
May 14, 2026
In the event the proposer has seen the payload timely and its local view of DA passes, the node will have the payload verified. However, if the PTC is signalling that the Payload blob data is not available, the proposer MUST reorg the payload. This PR implements this mechanism with a few caveats. - Most importantly, currently it is very aggressive and if there are no PTC attestations the proposer will be forced to reorg the payload. There are many solutions to this problem like simply counting the PTC attestations (which is also a way of counting the NAY votes) or using #5180. If we go with #5180 this PR needs to be accomodated to that and actually count the NAY votes. - The threshold could be different than 50%. - The proposer may have all the data available locally and decide to build on full even though the PTC voted no. I think it's better to leave that unspecified.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates Gloas fork-choice to represent PTC payload votes as
Optional[boolean]instead ofboolean.Previously,
Falserepresented both "nay" and "no vote observed" forpayload_timeliness_voteandpayload_data_availability_vote.Now
NonevsFalsecan allow the fork-choice todistinguish missing votes from explicit negative votes.
This distinction is useful for detecting and attributing builder timing
games, especially repeated cases where bids are made but payloads or blob data
are not available to the PTC by the relevant deadline.