Fix genesis state in Gloas - #5172
Conversation
| # Chain onto the previous bid so both block_1 and block_2 see a FULL parent | ||
| bid.parent_block_hash = state.latest_execution_payload_bid.block_hash | ||
| bid.block_hash = state.latest_execution_payload_bid.block_hash | ||
| # TODO(jtraglia): make this less hacky |
There was a problem hiding this comment.
is this a thing we're fixing now? or are we merging this todo?
There was a problem hiding this comment.
I intend to merge this todo & deal with it later. The fix wouldn't be simple.
nflaig
left a comment
nflaig
left a comment
There was a problem hiding this comment.
Looks good to me, I haven't verified if that allows to revert all hacks we added in lodestar for it, but it should
| bid.block_hash = state.latest_execution_payload_bid.block_hash | ||
| # TODO(jtraglia): make this less hacky | ||
| bid.parent_block_hash = state.latest_block_hash | ||
| bid.block_hash = state.latest_block_hash |
There was a problem hiding this comment.
I don't understand how this can ever happen
There was a problem hiding this comment.
Yeah I hate this. This is unrealistic but that's how the test worked before. This test format does not yet support payload sidecars. See: https://github.com/ethereum/consensus-specs/blob/master/tests/formats/sanity/blocks.md
confirmed we are passing spec tests based on the changes in this PR without any genesis block checks |
This reverts commit e9f599e.
4 participants
Make the suggested change from #5168: