In networking tests, yield values after mutating them - #5050
Merged
Conversation
Member
Author
|
Generated reference tests: reftests.zip |
jihoonsong
approved these changes
Apr 7, 2026
jtraglia
enabled auto-merge (squash)
April 13, 2026 22:35
jtraglia
added a commit
that referenced
this pull request
May 7, 2026
This PR makes some fixes to the gossip validation tests. Clients have begun running these and have provided helpful feedback. For the most part, #5050 was incorrect (meaning it was correct before that change).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a lot of tests, it seems that we were yielding the state before mutating it. Apparently, this didn't break the test cases though (cc @nflaig). See also: #4902