Skip to content

Port kzg_7594 tests to pytest#4654

Merged
jtraglia merged 3 commits into
ethereum:masterfrom
leolara:leolara/port-zkg-7594.py
Oct 16, 2025
Merged

Port kzg_7594 tests to pytest#4654
jtraglia merged 3 commits into
ethereum:masterfrom
leolara:leolara/port-zkg-7594.py

Conversation

@leolara

@leolara leolara commented Oct 13, 2025

Copy link
Copy Markdown
Member

It is a port of KZG 7594 tests to pytest.

Note: I left the origina code disabled temporarily in order to be able to compare the vectors.

@leolara leolara requested a review from jtraglia October 13, 2025 23:10
@leolara leolara added the testing CI, actions, tests, testing infra label Oct 14, 2025
@jtraglia

Copy link
Copy Markdown
Member

Let's fix the comments. Remove unnecessary ones & convert useful ones to docstrings.

@leolara

leolara commented Oct 15, 2025

Copy link
Copy Markdown
Member Author

Let's fix the comments. Remove unnecessary ones & convert useful ones to docstrings.

Yes, I will review the comments

@leolara

leolara commented Oct 15, 2025

Copy link
Copy Markdown
Member Author

Check the comments when you can @jtraglia

@jtraglia

Copy link
Copy Markdown
Member

Can confirm the generated tests match master:

image

@jtraglia jtraglia changed the title Port KZG 7594 to pytest Port kzg_7594 tests to pytest Oct 16, 2025

@jtraglia jtraglia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @leolara!

@jtraglia jtraglia merged commit d0548db into ethereum:master Oct 16, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing CI, actions, tests, testing infra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants