Skip to content

Set default value of BuilderPendingPayment.withdrawable_epoch to FAR_FUTURE_EPOCH #4631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtraglia merged 6 commits into from
Oct 16, 2025
Merged

Set default value of BuilderPendingPayment.withdrawable_epoch to FAR_FUTURE_EPOCH #4631

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
00d1542
Small fixes to Gloas spec
ensi321 Oct 2, 2025
103b8a0
lint
ensi321 Oct 2, 2025
cf7a944
Update is_builder_payment_withdrawable
ensi321 Oct 6, 2025
543635c
Merge branch 'master' into gloas-small-fixes
ensi321 Oct 15, 2025
336195f
Update condition
ensi321 Oct 15, 2025
934934d
Address comment
ensi321 Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion specs/gloas/beacon-chain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,7 @@ def is_builder_payment_withdrawable(
"""
builder = state.validators[withdrawal.builder_index]
current_epoch = compute_epoch_at_slot(state.slot)
return builder.withdrawable_epoch >= current_epoch or not builder.slashed
return current_epoch > withdrawable.withdrawable_epoch or builder.slashed
Comment thread
ensi321 marked this conversation as resolved.
Outdated
```

##### Modified `get_expected_withdrawals`
Expand Down Expand Up @@ -1029,6 +1029,7 @@ def process_execution_payload_bid(state: BeaconState, block: BeaconBlock) -> Non
fee_recipient=bid.fee_recipient,
amount=amount,
builder_index=builder_index,
withdrawable_epoch=FAR_FUTURE_EPOCH,
),
)
state.builder_pending_payments[SLOTS_PER_EPOCH + bid.slot % SLOTS_PER_EPOCH] = pending_payment
Expand Down
2 changes: 1 addition & 1 deletion specs/gloas/validator.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ def get_data_column_sidecars_from_column_sidecar(
assert len(cells_and_kzg_proofs) == len(sidecar.kzg_commitments)

return get_data_column_sidecars(
sidecar.signed_block_header.message.body_root,
sidecar.beacon_block_root,
Comment thread
ensi321 marked this conversation as resolved.
sidecar.kzg_commitments,
cells_and_kzg_proofs,
)
Expand Down
Loading