eip7732: remove header and inclusion proof from data column sidecar #4527
+152
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@terencechain you need to update |
3 tasks
Member
|
Also, we need new tests here |
terencechain
commented
Sep 5, 2025
| ### Modified `get_data_column_sidecars_from_column_sidecar` | ||
|
|
||
| ```python | ||
| def get_data_column_sidecars_from_column_sidecar( |
Contributor
Author
There was a problem hiding this comment.
help needed: I had to add this to get the lint to pass and I dont know why
Member
There was a problem hiding this comment.
We had to add this function because we changed the definition of get_data_column_sidecars which it calls. Without the tests which use it would call that function with the wrong arguments. This seems fine to me.
fradamt
reviewed
Sep 9, 2025
specs/gloas/p2p-interface.md
Outdated
Comment on lines
44
to
46
| ### Preset | ||
|
|
||
| *[Modified in Gloas:EIP7732]* | ||
|
|
||
| | Name | Value | Description | | ||
| | --------------------------------------------- | ----- | ----------------------------------------------------------- | | ||
| | `KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH_GLOAS` | `9` | Merkle proof depth for the `blob_kzg_commitments` list item | | ||
| *No changes in Gloas.* |
Contributor
There was a problem hiding this comment.
Let's just remove the Preset section then?
fradamt
approved these changes
Sep 9, 2025
terencechain
force-pushed
the
update-column-sidecar
branch
from
808d8aa to
8427d6b
Compare
jtraglia
changed the title
jtraglia
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR removes the header and inclusion proof from the data column sidecar, based on the assumption that the beacon block containing the bid and KZG commitment root is received before the data column sidecar. The reason these fields exist today is that sidecars and blocks are broadcast at the same time.