Skip to content

Test generator: allow customization of CLI argument parser #4339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025
Merged

Test generator: allow customization of CLI argument parser #4339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ab4382
Allow passing externally parsed arguments to `run_generator`
ericsson49 May 27, 2025
0862295
Split `parse_arguments` into two steps: creating a parser and parsing…
ericsson49 May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tests/core/pyspec/eth2spec/gen_helpers/gen_base/args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import pathlib


def parse_arguments():
def create_arg_parser() -> argparse.ArgumentParser:
parser = argparse.ArgumentParser(
prog="generator",
description=f"Generate YAML test suite files.",
Expand Down Expand Up @@ -70,4 +70,8 @@ def parse_arguments():
default=os.cpu_count(),
help="Generate tests with N threads. Defaults to core count.",
)
return parser.parse_args()
return parser


def parse_arguments():
return create_arg_parser().parse_args()
5 changes: 3 additions & 2 deletions tests/core/pyspec/eth2spec/gen_helpers/gen_base/gen_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,10 @@ def execute_test(test_case: TestCase, dumper: Dumper):
dumper.dump_meta(test_case, meta)


def run_generator(input_test_cases: Iterable[TestCase]):
def run_generator(input_test_cases: Iterable[TestCase], args=None):
start_time = time.time()
args = parse_arguments()
if args is None:
args = parse_arguments()

# Bail here if we are checking modules.
if args.modcheck:
Expand Down