-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Introduce blob schedule #4277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Introduce blob schedule #4277
Changes from 27 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
4d2f29b
Add parsing for blob schedule table
jtraglia 43b3a29
add parser for config in yaml
GabrielAstieres e736f28
improve regex
GabrielAstieres c790cec
add get_max_blobs_per_block
GabrielAstieres fcda062
remove MAX_BLOBS_PER_BLOCK_FULU
GabrielAstieres 6324589
revamp get_max_blob_count
GabrielAstieres f1deb42
address Justin comments
GabrielAstieres 9e479b5
Merge branch 'dev' into blob-schedule
jtraglia 5b69bc2
Simplify blob schedule table
jtraglia 1cf0f03
Clean up parse_config_vars function
jtraglia c0d8595
Improve testing just a little
jtraglia d3c21d8
Check/overwrite blob schedule with config file
jtraglia 5501ac1
Remove assert and fix tests
jtraglia d2a4253
Fix lint & update minimal blob schedule
jtraglia 75163d6
Improve list of records parsing
jtraglia 2133a54
Merge branch 'ethereum:dev' into blob-schedule
GabrielAstieres be5578b
remove BPO
GabrielAstieres 918dcb1
fix test_incorrect_blob_tx_type
GabrielAstieres 2752acc
fix block processing tests
GabrielAstieres 6d1027d
linting changes
GabrielAstieres 80e9f23
fix test_get_max_blobs
GabrielAstieres 5f47501
hardcode fork epoch in test
GabrielAstieres e2dfe47
Revamp max blobs getter to default to electra limit
GabrielAstieres 40c1370
Merge branch 'dev' into blob-schedule
jtraglia c0088d1
add EOF lines
GabrielAstieres 6ba03b5
Add special condition to get_max_blobs_per_block
jtraglia fb9f20f
Simplify
jtraglia 7c5b431
Use EIP7892 in modified comment
jtraglia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a
MAX_BLOBS_PER_BLOCKfor fulu?Currently how this is drafted,
get_max_blobs_per_block()will return 9 during fulu.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, during the 2nd to last PeerDAS breakout call we decided to remove any placeholder blob limit increases. We can decide these in a future PR. This PR just lays the foundation for that. Also, the current plan initially is to keep the Electra blob limit at the fork, then 2x two weeks later, then 2x two months later, and 2x once again another two months later. Resulting 72 blobs per block 4.5 months after Fulu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how did we come up with that number btw? 2 weeks doesn't provide us any value, it's not sufficient to analyse the data on the network and push out new client releases + get everyone to update, minimum should be 2 months imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from Alex Stokes's proposal: blob/acc in 2025. There's a some rationales in there. To be clear, this is just his proposed schedule. Nothing has been decided yet. And this discussion is out-of-scope for this PR 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really see much rationale there but saw someone else left similar comment on the document, but agree this is out of scope of the PR 😁