Skip to content

Fix eip7732 kzg commitment inclusion proof depth #4264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025
Merged

Fix eip7732 kzg commitment inclusion proof depth #4264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e849082
Update inclusion proof depth for mainnet
jtraglia Apr 11, 2025
131839d
Disable two fork-choice tests for now
jtraglia Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion presets/mainnet/eip7732.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@
PTC_SIZE: 512
# 2**2 (= 4)
MAX_PAYLOAD_ATTESTATIONS: 4
KZG_COMMITMENT_INCLUSION_PROOF_DEPTH_EIP7732: 13
# floorlog2(get_generalized_index(BeaconBlockBody, 'blob_kzg_commitments')) + 1 + ceillog2(MAX_BLOB_COMMITMENTS_PER_BLOCK) (= 8 + 1 + 12 = 21)
KZG_COMMITMENT_INCLUSION_PROOF_DEPTH_EIP7732: 21
1 change: 1 addition & 0 deletions presets/minimal/eip7732.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@
PTC_SIZE: 2
# 2**2 (= 4)
MAX_PAYLOAD_ATTESTATIONS: 4
# floorlog2(get_generalized_index(BeaconBlockBody, 'blob_kzg_commitments')) + 1 + ceillog2(MAX_BLOB_COMMITMENTS_PER_BLOCK) (= 8 + 1 + 5 = 14)
KZG_COMMITMENT_INCLUSION_PROOF_DEPTH_EIP7732: 14
2 changes: 1 addition & 1 deletion specs/_features/eip7732/p2p-interface.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ The specification of these changes continues in the same format as the network s

| Name | Value | Description |
| ---------------------------------------------- | ------------ | ----------------------------------------------------------- |
| `KZG_COMMITMENT_INCLUSION_PROOF_DEPTH_EIP7732` | `13` **TBD** | Merkle proof depth for the `blob_kzg_commitments` list item |
| `KZG_COMMITMENT_INCLUSION_PROOF_DEPTH_EIP7732` | `21` **TBD** | Merkle proof depth for the `blob_kzg_commitments` list item |

### Configuration

Expand Down
7 changes: 5 additions & 2 deletions tests/core/pyspec/eth2spec/test/phase0/fork_choice/test_ex_ante.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from eth2spec.test.context import (
spec_state_test,
with_altair_and_later,
with_altair_until_eip7732,
with_presets,
)
from eth2spec.test.helpers.attestations import (
Expand Down Expand Up @@ -135,7 +136,8 @@ def _get_greater_than_proposer_boost_score(spec, store, state, proposer_boost_ro
return proposer_score // base_effective_balance + 1


@with_altair_and_later
# TODO(jtraglia): Investigate why this doesn't work with eip7732
@with_altair_until_eip7732
@with_presets([MAINNET], reason="to create non-duplicate committee")
@spec_state_test
def test_ex_ante_attestations_is_greater_than_proposer_boost_with_boost(spec, state):
Expand Down Expand Up @@ -370,7 +372,8 @@ def _filter_participant_set(participants):
yield "steps", test_steps


@with_altair_and_later
# TODO(jtraglia): Investigate why this doesn't work with eip7732
@with_altair_until_eip7732
@with_presets([MAINNET], reason="to create non-duplicate committee")
@spec_state_test
def test_ex_ante_sandwich_with_boost_not_sufficient(spec, state):
Expand Down