Skip to content

Allow skipping verification for blobs from EL #4262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

Allow skipping verification for blobs from EL #4262

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2169144
Allow skipping verification for blobs from EL
dguenther Apr 10, 2025
7afacb5
Try combining with other section
dguenther Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions specs/fulu/p2p-interface.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,8 @@ The following validations MUST pass before forwarding the `sidecar: DataColumnSi

Honest nodes SHOULD query `engine_getBlobsV2` as soon as they receive a valid `beacon_block` or `data_column_sidecar` from gossip. If ALL blobs matching `kzg_commitments` are retrieved, they should convert the response to data columns, and import the result.

Clients SHOULD assume the execution layer is trusted and skip verification for blobs retrieved from it.
Copy link

@mininny mininny Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I think it could be good to incorporate this into this part (two lines below)

When clients use the local execution layer to retrieve blob and compute data columns, they MUST behave as if the imported data_column_sidecar had been received via gossip. In particular, clients MUST:
→ it MUST behave ~ received via gossip, except ~

Copy link
Contributor Author

@dguenther dguenther Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have misunderstood what you meant, but I revised it to combine with the section below. Let me know if you think that looks good, otherwise I'm happy to iterate on it more.

Copy link
Member

@jtraglia jtraglia Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new version. And I agree this is the appropriate spot for the note.


Implementers are encouraged to leverage this method to increase the likelihood of incorporating and attesting to the last block when its proposer is not able to publish data columns on time.

When clients use the local execution layer to retrieve blob and compute data columns, they MUST behave as if the imported `data_column_sidecar` had been received via gossip. In particular, clients MUST:
Expand Down