EIP-7251: Fix off-by-one in churn computations#3682
Merged
Conversation
Contributor
|
lgtm |
hwwhww
changed the title
ralexstokes
approved these changes
Apr 17, 2024
Member
ralexstokes
left a comment
ralexstokes
left a comment
There was a problem hiding this comment.
looks good!
I like that we are getting rid of divmod as that felt a bit more pythonic to me than we really want in the specs generally
and I do think we should refactor into one common compute_epoch_and_balance_to_process or something but we can do that later
13 tasks
Contributor
Author
I attempted to do that but the call to such method looks really cumbersome because of a number of params passed onto it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3677
This PR refactors churn computations and resolves the above issue. Ideally, we would have one method handling computation for both churns if a number of parameters involved in the computation were lower, it is just ugly to pass four params to a method with four lines of code and would hinder readability IMO.